Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PumiceDBClient.go::Write() should not return an unsafe.Pointer #3

Open
00pauln00 opened this issue Dec 19, 2023 · 1 comment
Open

PumiceDBClient.go::Write() should not return an unsafe.Pointer #3

00pauln00 opened this issue Dec 19, 2023 · 1 comment
Assignees
@manishasalve @akshata0305 @Paroscale-Shirisha
Labels
help wanted Extra attention is needed

Comments

@00pauln00
Copy link
Owner

The unsafe.Pointer returned in Write() is only done if PmdbReqArgs::GetResponse is set. Since PmdbReqArgs contains Response *[]byte the pointer contents may be placed there instead of being returned.

In addition, PumiceDBClient.go::writeKV() should take PmdbReqArgs and do the necessary reply copying into PmdbReqArgs::Response.

niova-pumicedb/go/pumiceDB/client/PumiceDBClient.go

Line 97 in 3c0456d

func (obj *PmdbClientObj) Write(reqArgs *PmdbReqArgs) (unsafe.Pointer, error) {

@00pauln00 00pauln00 added the invalid This doesn't seem right label Dec 19, 2023
@00pauln00 00pauln00 added help wanted Extra attention is needed and removed invalid This doesn't seem right labels Dec 19, 2023
@ashwini-8
Copy link
Collaborator

Added changes in branch
#7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manishasalve manishasalve

@akshata0305 akshata0305

@Paroscale-Shirisha Paroscale-Shirisha

Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@00pauln00 @ashwini-8 @manishasalve @akshata0305 @Paroscale-Shirisha