PmdbWriteKV(), WriteKV(), PmdbLookupKey(), PmdbReadKV() & ReadKV() -- Parameters Need Improvements

[00pauln00]

func PmdbWriteKV(app_id unsafe.Pointer, pmdb_handle unsafe.Pointer, key string, key_len int64, 
                               value string, value_len int64, gocolfamily string) int {

1. Can we not simply use PumiceDBServer.PmdbCbArgs instead of the first 2 parameters? This would reduce the parameter list and prevent the passing of 2 unsafe.Pointers.
2. key and value need to be of type []byte.

Here's an example from https://github.com/linxGnu/grocksdb/blob/master/write_batch.go

// Put queues a key-value pair.
func (wb *WriteBatch) Put(key, value []byte) {
	cKey := refGoBytes(key)
	cValue := refGoBytes(value)
	C.rocksdb_writebatch_put(wb.c, cKey, C.size_t(len(key)), cValue, C.size_t(len(value)))
}

On the read side, PmdbReadKV() and friends (including LookupKey()) should use PumiceDBServer.PmdbCbArgs instead of unsafe.Pointer and []byte instead of string.

niova-pumicedb/go/pumiceDB/server/PumiceDBServer.go

Line 391 in 3c0456d

func PmdbWriteKV(app_id unsafe.Pointer, pmdb_handle unsafe.Pointer, key string,

[ashwini-8]

pushed changes to this branch
#6