Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify shared constants into a common public module #261

Closed
Nashtare opened this issue Jun 5, 2024 · 1 comment · Fixed by #500
Closed

Unify shared constants into a common public module #261

Nashtare opened this issue Jun 5, 2024 · 1 comment · Fixed by #500
Assignees
@atanmarko
Labels
crate: evm_arithmetization Anything related to the evm_arithmetization crate. crate: mpt_trie Anything related to the mpt_trie crate. crate: proof_gen Anything related to the proof_gen crate. crate: trace_decoder Anything related to the trace_decoder crate. crate: zero_bin Anything related to the zero-bin subcrates.
Milestone
System strengthening

Comments

@Nashtare
Copy link
Collaborator

Nashtare commented Jun 5, 2024

cf this comment.

We redefine several times identical constants at different levels (mpt_trie, evm_arithmetization, zero-bin, ...) which could be defined once and re-exported where needed out of clarity & safety.
@Nashtare Nashtare added this to the Cleanups and Misc. milestone Jun 5, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Zero EVM Jun 5, 2024
@Nashtare Nashtare added crate: trace_decoder Anything related to the trace_decoder crate. crate: proof_gen Anything related to the proof_gen crate. crate: evm_arithmetization Anything related to the evm_arithmetization crate. crate: mpt_trie Anything related to the mpt_trie crate. crate: zero_bin Anything related to the zero-bin subcrates. labels Jun 14, 2024
@Nashtare
Copy link
Collaborator Author

Including the zero-bin crate as well, as some constants that weren't exposed by the API were re-defined identically there.

@Nashtare Nashtare modified the milestone: Cleanups and Misc. Jun 27, 2024
@Nashtare Nashtare mentioned this issue Jul 1, 2024
Merged
@Nashtare Nashtare modified the milestones: Misc., System strengthening Jul 12, 2024
@atanmarko atanmarko mentioned this issue Aug 15, 2024
Merged
@github-project-automation github-project-automation bot moved this from Backlog to Done in Zero EVM Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atanmarko atanmarko

Labels
crate: evm_arithmetization Anything related to the evm_arithmetization crate. crate: mpt_trie Anything related to the mpt_trie crate. crate: proof_gen Anything related to the proof_gen crate. crate: trace_decoder Anything related to the trace_decoder crate. crate: zero_bin Anything related to the zero-bin subcrates.
Projects
Zero EVM
Status: Done
Milestone
System strengthening
Development

Successfully merging a pull request may close this issue.

chore: add common crate for project wide definitions 0xPolygonZero/zk_evm
2 participants
@atanmarko @Nashtare