This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
Use AssetBuyer for orders with fees #561
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When fees exist on the order we use AssetBuyer to buy via the Forwarder rather than the Forwarder directly.
Fixes #557 0xProject/0x-launch-kit#22
Example Tx
Fees on MKR and fees on ZRX orders used to pay the fees.
We're using AssetBuyer here for future proofing even though it makes an additional 2 requests for the order books. This will help when fees move from ZRX to another token rather than front end keeping a special cased list of ZRX orders.