Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Badges with deep endorsement trees fail validation #231

Open
ottonomy opened this issue Feb 6, 2020 · 0 comments
Open

Badges with deep endorsement trees fail validation #231

ottonomy opened this issue Feb 6, 2020 · 0 comments

Comments

@ottonomy
Copy link
Collaborator

ottonomy commented Feb 6, 2020

The validator doesn't ever know to stop validating endorsements of objects. So if there are lots of them, it takes a long time to make a request, and that request is likely to time out. There should be some limit to the amount of endorsements that are checked, and potentially more complex solutions that enable some checking of relevant endorsements but does not block verification of the key object.

Validation / verification of endorsements should not block validity of the core validation subject. Validity of those endorsements should be reported back by the validator separately and optionally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant