Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking on a button that closes the window may trigger an exception #76

Open
acolomitchi opened this issue Mar 16, 2018 · 0 comments
Open

Comments

@acolomitchi
Copy link

acolomitchi commented Mar 16, 2018

Repro using the standard "FileOpenDialog":

  1. set the content of the address toolbar and filename combos to point to an existing file
  2. trigger a click on the "Open" button

Chances are the dialog closes fast enough for the Logger.Info(..._ calls in TryClick... methods in CruciatusCommands.cs to find a now-invalid Element, which will cause an exception while trying to format the message. In my case, it happened more often than not.

Suggestion: format the message in advance into a local variable before performing the click action, use the formatted message with Logger.Info after performing the click action.

acolomitchi added a commit to acolomitchi/Winium.Cruciatus that referenced this issue Mar 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant