From 8837c6e8f48f8c36d25150c1f108da22f92b0608 Mon Sep 17 00:00:00 2001 From: Wes Cummings Date: Thu, 14 Nov 2024 17:48:11 +0000 Subject: [PATCH 1/2] updating version --- DESCRIPTION | 2 +- NEWS.md | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/DESCRIPTION b/DESCRIPTION index 40f2660..6c4d156 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,6 +1,6 @@ Package: ghqc Title: Manage QC via GitHub Issues using Shiny Apps -Version: 0.1.7 +Version: 0.1.8 Authors@R: c( person("Anne", "Zheng", email = "anne@a2-ai.com", role = c("aut")), person("Jenna", "Johnson", email = "jenna@a2-ai.com", role = c("aut")), diff --git a/NEWS.md b/NEWS.md index 1fabf31..0bc5730 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,3 +1,7 @@ +# ghqc 0.1.8 + +- The logic for rejecting `gert` install as part of `setup_ghqc` was incorrect. Updating to allow for rejection + # ghqc 0.1.7 - typo found in `setup_ghqc` related to the info repo global variable. No performance change From d039c0efa122e3c578f31734624c4960210df01a Mon Sep 17 00:00:00 2001 From: Wes Cummings Date: Thu, 14 Nov 2024 17:48:56 +0000 Subject: [PATCH 2/2] changing and to or in gert install response logic --- R/interactive_setup.R | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/R/interactive_setup.R b/R/interactive_setup.R index 0f5c5a0..44d8166 100644 --- a/R/interactive_setup.R +++ b/R/interactive_setup.R @@ -63,7 +63,7 @@ interactive_info_download <- function() { cli::cli_inform(c("!" = "Package {.code gert} is not found in your project package library", " " = "The configuration information repository cannot be downloaded unless this package is present")) yN <- gsub('\"', "", readline("Would you like to install `gert` to continue? (y/N) ")) - if (yN != "y" && yN == "") { + if (yN != "y" || yN == "") { cli::cli_alert_danger("`gert` is not installed. Configuring information repository cannot be checked or downloaded using this package") return(invisible()) }