Converted coffeescript files into JS #575
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compiled js files using npm coffeescript pacakge. Note: This technically makes all javascript files have the same scope as I removed the IIFE that the compiler generated by default
|
We should also remove any Coffeescript related configuration or non-standard packages. I assume |
|
Removed all references to coffee I could find including loaders. Also I tested assets:precompile and it works based on my limited testing |
DaAwesomeP
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiled js files using npm coffeescript pacakge.
Note: This technically makes all javascript files have the same scope as I removed the IIFE that the compiler generated by default
Should solve #541