Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal] Improve Logging to be more relevant - collect more info on what we don't expect and less of what we do #38

Open
don-de-marco opened this issue Jun 27, 2023 · 1 comment

Comments

@don-de-marco
Copy link

don-de-marco commented Jun 27, 2023

Steam may send some notification events to us although we might not have explicitly asked for information. For example, when you stop playing a game, we'll receive this notification from the Steam backend, which we currently just ignore:

2023-06-27 00:27:00,833 - steam_network.protocol.protobuf_client - INFO - Processing message ServiceMethodResponse PlayerClient.NotifyLastPlayedTimes#1
2023-06-27 00:27:00,833 - steam_network.protocol.protobuf_client - WARNING - Unparsed message, no idea what it is. Tell me
2023-06-27 00:27:00,833 - steam_network.protocol.protobuf_client - WARNING - job name: "PlayerClient.NotifyLastPlayedTimes#1"

We're already handling some of them but I believe there were some changes and we should pay a bit of attention to them at some point. It's nothing that is broken or non-functional but something that we could use to notify Galaxy of changes ahead of their own polling mechanism.

@ABaumher ABaumher changed the title [Internal] collect and listen to more notification messages sent by steam [Internal] Improve Logging to be more relevant - unexpected steam messages etc. Jul 5, 2023
@ABaumher
Copy link
Owner

ABaumher commented Jul 5, 2023

On a related note: can/should we set the json-rpc log level to warning or higher so we can have smaller log files? I feel like a lot of the info calls don't tell us anything and make finding errors immensely more tedious. It would increase our reliance on the galaxy client log to track down some misbehaving code but we already need than anyway.

@ABaumher ABaumher changed the title [Internal] Improve Logging to be more relevant - unexpected steam messages etc. [Internal] Improve Logging to be more relevant - collect more info on what we don't expect and less of what we do Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants