Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment Infrastructure V4: Multi-HPC Deployments #40

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

CodeGat
Copy link
Member

@CodeGat CodeGat commented Jan 29, 2025

References issue ACCESS-NRI/build-cd#121 and detailed PR ACCESS-NRI/build-cd#218

Important

This PR is a major update to the deployment infrastructure. See below for the prerequisites for this repository to be able to merge this PR.

Background

This update to the deployment infrastructure allows deployment to multiple different HPC systems (or the same one but a different spack instance) in parallel.

Some of the major changes relevant to a model deployment repository include:

Prerequisites for Merging

  • Add values for repo-level vars.[PRE]RELEASE_DEPLOYMENT_TARGETS
  • Update repo-level vars.SPACK_YAML_SCHEMA_VERSION to 1-0-4
  • Update entrypoints to @v4, update ci.yml pr-closed jobs model input to root-sbd, update cd.yml cd job permissions.pull-requests:write (This PR!)
  • Add GitHub Environment for Releases with name SUPERCOMPUTER Release rather than SUPERCOMPUTER

@CodeGat CodeGat added the type:infra Related to CI/CD label Jan 29, 2025
@CodeGat CodeGat self-assigned this Jan 29, 2025
@CodeGat CodeGat marked this pull request as ready for review February 4, 2025 22:44
@anton-seaice
Copy link
Contributor

Does this need a change to the spack.yaml or does the current format work?

Can I deploy twice to Gadi with different compilers ?

@CodeGat
Copy link
Member Author

CodeGat commented Feb 4, 2025

The current format works fine!
And yes, technically you could - although each compiler that you would want to test with would have to be it's own GitHub Environment, which means it's own spack instance. i suppose you could set the environment to the same instance, but the issue would then be that there is nothing the demarcate the packages...I think for now it's a 'technically possible but haven't thought too deeply about that use case'

@anton-seaice
Copy link
Contributor

Ok - so we should merge this ?

@CodeGat
Copy link
Member Author

CodeGat commented Feb 4, 2025

That would be good. It'd require a rebase to open PRs to propagate the changes from main to the PR branch, if you wanted to use it for existing PRs. Keep me in the loop regarding how it's going!

Copy link
Contributor

@anton-seaice anton-seaice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update with new versions from build-cd

@CodeGat CodeGat merged commit b300a6c into main Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:infra Related to CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants