You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Running the test from the workflow results in a failure status - despite exit status 0 being returned from the PBS job.
Additional things to note
The workflow currently runs using @rbeucher's Gadi account, using the version of access-nri-intake-catalog contained within conda/analysis3-24.12, against the tests in /g/data/xp65/admin/access-nri-intake-catalog, from whatever branch is specified by the user in the workflow. This is fraught with potential errors, including but probably not limited to:
Git branch mismatch - If you run the workflow from branch x, but /g/data/xp65/admin/access-nri-intake-catalog is checked out to branch y, then the workflow will run against the tests contained in branch y, not x.
Package version mismatch: If the tests in branch y at /g/data/xp65/admin/access-nri-intake-catalog refer to or test changes introduced to the package since the released packaged installed in conda/analysis3-24.12, the tests will fail.
Describe the feature you'd like
The workflow should checkout the head commit of the branch it is triggered from, locally install that package version, and then run the end to end tests against that, before reporting back to the workflow.
This is currently not easily achievable without creating a bunch of build artefacts (virtual environments, PBS output, etc) in @rbeucher's user area. Creating a service user to handle this would be ideal.
Describe alternatives you've considered
N/A.
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
The end to end build test workflow is currently problematic.
Additional things to note
access-nri-intake-catalog
contained withinconda/analysis3-24.12
, against the tests in/g/data/xp65/admin/access-nri-intake-catalog
, from whatever branch is specified by the user in the workflow. This is fraught with potential errors, including but probably not limited to:x
, but/g/data/xp65/admin/access-nri-intake-catalog
is checked out to branchy
, then the workflow will run against the tests contained in branchy
, notx
.y
at/g/data/xp65/admin/access-nri-intake-catalog
refer to or test changes introduced to the package since the released packaged installed inconda/analysis3-24.12
, the tests will fail.Describe the feature you'd like
The workflow should checkout the head commit of the branch it is triggered from, locally install that package version, and then run the end to end tests against that, before reporting back to the workflow.
This is currently not easily achievable without creating a bunch of build artefacts (virtual environments, PBS output, etc) in @rbeucher's user area. Creating a service user to handle this would be ideal.
Describe alternatives you've considered
N/A.
The text was updated successfully, but these errors were encountered: