-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
025deg jra55do ryf.cherrypicks #103
025deg jra55do ryf.cherrypicks #103
Conversation
Flag OCN_modelio::pio_* params as unused in nuopc.runconfig remove extra lines in nuopc.runconfig update comment for ocean nc type
I think ditch the setup user script here. That's what we'll do for the other configs anyway once the symlink workaround is no longer required. If you think it's important to make an initial condition file, that should be done in a subsequent PR |
0fc95c0
to
0bd3126
Compare
I ran two adhoc tests:
|
0bd3126
to
f585b89
Compare
nuopc.runconfig
Outdated
@@ -288,13 +288,13 @@ CLOCK_attributes:: | |||
lnd_cpl_dt = 99999 #not used | |||
ocn_cpl_dt = 1350 #ignored (coupling timestep set by nuopc.runseq) unless stop_option is nsteps | |||
restart_n = 1 | |||
restart_option = nyears | |||
restart_option = ndays |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really want to change this?
- work-around symlink restart bug in CICE - concatenate CICE daily output - auto-generate an intake-esm datastore
…er at this point, and the userscript to concat ice daily output expects the default name to be used. See COSIMA/access-om3#201
f585b89
to
883e870
Compare
Oops sorry - I fixed it. third time lucky! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and seems to run successfully
Companion PR to #91
This fails as there is no
input/iced.1900-01-01-10800.nc
in this configuration, as we useice_ic=default
. The iced file is expected by the setup user script.We could just not use the setup user script, or change the user script, or make the initial condition file. Thoughts @dougiesquire ?