Fix bug in nuopc.runconfig by removing the equal sign ('=') from comments (after '#')

[minghangli-uni]

Fix bug caused by the equal sign '=' from comments (after '#')

...
  72 [gadi-cpu-clx-0238:1008973:0:1008973] Caught signal 11 (Segmentation fault: address not mapped to object at address 0x65d8)
  73 [gadi-cpu-clx-0238:1008975:0:1008975] Caught signal 11 (Segmentation fault: address not mapped to object at address 0x65d8)
  74 ==== backtrace (tid:1008976) ====
  75  0 0x0000000000012d20 __funlockfile()  :0
  76  1 0x0000000002e01faf mom_mp_mom_state_is_synchronized_()  /jobfs/121983958.gadi-pbs/ds0092/spack-stage/spack-stage-access-om3-63ed4a4777aeac0c6     2720ddbe7f85e4ed16f82eb_main-xekfuu46z2ztbywtak2u3oenjedrynn4/spack-src/MOM6/MOM6/src/core/MOM.F90:3861
  77  2 0x0000000002d749df mom_ocean_model_nuopc_mp_ocean_model_restart_()  /jobfs/121983958.gadi-pbs/ds0092/spack-stage/spack-stage-access-om3-63ed4     a4777aeac0c62720ddbe7f85e4ed16f82eb_main-xekfuu46z2ztbywtak2u3oenjedrynn4/spack-build-xekfuu4/MOM6/mom_ocean_model_nuopc.F90:721
  78  3 0x0000000002d35716 mom_cap_mod_mp_modeladvance_()  /jobfs/121983958.gadi-pbs/ds0092/spack-stage/spack-stage-access-om3-63ed4a4777aeac0c62720d     dbe7f85e4ed16f82eb_main-xekfuu46z2ztbywtak2u3oenjedrynn4/spack-build-xekfuu4/MOM6/mom_cap.F90:1955
  79  4 0x00000000020a637f ESMCI::MethodElement::execute()  /jobfs/115061931.gadi-pbs/mo1833/spack-stage/spack-stage-esmf-8.5.0-ox5q2shmsrzlmmckqxwqg     vaih7zxxthj/spack-src/src/Superstructure/Component/src/ESMCI_MethodTable.C:377
...
2783 45 0x000000000043150d main()  ???:0
2784 46 0x000000000003a7e5 __libc_start_main()  ???:0
2785 47 0x000000000043142e _start()  ???:0
2786 =================================
2787 --------------------------------------------------------------------------
2788 mpirun noticed that process rank 9 with PID 0 on node gadi-cpu-clx-0238 exited on signal 11 (Segmentation fault).
2789 --------------------------------------------------------------------------

This fix resolves the above error.

[anton-seaice]

Another vote for repro-ci!

Have these changes been cherry-picked to other repos?

[minghangli-uni]

Yep, the change was cherry-picked to 1deg iaf and 025deg ryf

[aekiss]

Nice sleuthing @minghangli-uni!

Getting tripped up by anything in a comment is pretty nasty behaviour in the nuopc.runconfig parser. If it's a bug introduced in a source update, should we report it upstream?

[minghangli-uni]

I doubt the issue was introduced by a recent source update. I’ll test it with an older build to see if it works. I can’t remember if I tested it before merging, as I didn’t expect this unusual behavior. But not using the equal sign does resolve the bug in our model.

[minghangli-uni]

!cherry-pick fb7ccd3 into 1deg_jra55do_iaf 025deg_jra55do_ryf

[github-actions]

Automatic Git cherry-picking of commit(s) fb7ccd3 into 1deg_jra55do_iaf failed. This usually happens when cherry-picking results in a conflic or an empty commit. To manually cherry-pick the commits and open a pull request, please follow these instructions:

1. Create new branch from target branch:

git checkout 1deg_jra55do_iaf
git pull
git checkout -b cherry_pick_from_pr98_into_1deg_jra55do_iaf

2. Cherry-pick commits:

git cherry-pick fb7ccd3

3. Fix any conflicts and/or empty commits by following the instructions provided by Git.
4. Push the new branch:

git push --set-upstream origin cherry_pick_from_pr98_into_1deg_jra55do_iaf

5. Open a new pull request on github making sure the target branch is set to 1deg_jra55do_iaf.

[github-actions]

Automatic Git cherry-picking of commit(s) fb7ccd3 into 025deg_jra55do_ryf failed. This usually happens when cherry-picking results in a conflic or an empty commit. To manually cherry-pick the commits and open a pull request, please follow these instructions:

1. Create new branch from target branch:

git checkout 025deg_jra55do_ryf
git pull
git checkout -b cherry_pick_from_pr98_into_025deg_jra55do_ryf

2. Cherry-pick commits:

git cherry-pick fb7ccd3

3. Fix any conflicts and/or empty commits by following the instructions provided by Git.
4. Push the new branch:

git push --set-upstream origin cherry_pick_from_pr98_into_025deg_jra55do_ryf

5. Open a new pull request on github making sure the target branch is set to 025deg_jra55do_ryf.