Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gen3-ff-rc-issues #1

Open
matthewpeterkort opened this issue Mar 8, 2024 · 0 comments
Open

Gen3-ff-rc-issues #1

matthewpeterkort opened this issue Mar 8, 2024 · 0 comments

Comments

@matthewpeterkort
Copy link
Collaborator

matthewpeterkort commented Mar 8, 2024

The following issues should be resolved with the frontend-framework repo for it to be able to be deployed to production

Button Styling
Button color / text styling should be hooked up to the color and font themes that can be specified in the config
and not just use default options. See login page buttons

Navigation Config
navigation bar Logo href redirect not wired up to navigation logo component in front-end package (hardcoded to "/")

Helm Additions
Update helm chart to mount data commons specific frontend-framework configuration files to the image. Especially environment variables which are host name specific.
Configs found here: https://github.com/uc-cdis/gen3-frontend-framework/tree/develop/packages/sampleCommons/config.

quinnwai added a commit that referenced this issue Aug 15, 2024
* update env config to cbds

* add this to enable build for aced commons

* update explorer config with ordering and subsets of columns, facets, and charts

* surface research subject tab and clean up explorer

* enable file modal on Research Subject tab

* refactor PatientDetailsPanel into more generalize ResourceDetailsPanel

* consolidate file ID into FileDetailsPanel table

---------

Co-authored-by: quinnwai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant