Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why logit checker has such a high tolerance? #1021

Open
hugoabonizio opened this issue Nov 11, 2024 · 0 comments
Open

Why logit checker has such a high tolerance? #1021

hugoabonizio opened this issue Nov 11, 2024 · 0 comments

Comments

@hugoabonizio
Copy link

Hi, I would like to understand why the comparison with the golden logits uses high absolute tolerance values, such as:

while some models achieve more similar results with smaller tolerances:

Why is this high tolerance needed? I understand we might expect numerical differences, but I was hoping for more similar results when implementations are equivalent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant