Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: What is the expected behavior for re-registration with smaller I/O count before the garbage collect interval? #215

Open
isaacgr opened this issue Nov 19, 2024 · 2 comments

Comments

@isaacgr
Copy link

isaacgr commented Nov 19, 2024

If a node dies and revives itself with a smaller I/O count within the garbage collect interval, and does not remember what it registered before it died (something I imagine it could use to delete its resources on startup) then what is the expected behavior?

What I'm seeing is that all the previous resources will remain in the registry. Since technically they never needed to get cleaned up as the node keepalive was never down long enough.

@garethsb
Copy link
Contributor

If the Node doesn't remember its previous state, it should treat finding itself in the Registry as unexpected and delete the Node resource, which will cause the Registry to remove all the subresources, before beginning the registration of all its current new resources starting with the Node again. See https://github.com/AMWA-TV/is-04/blob/v1.3.x/docs/Behaviour%20-%20Registration.md#node-encounters-http-200-on-first-registration

@isaacgr
Copy link
Author

isaacgr commented Nov 19, 2024

If the Node doesn't remember its previous state, it should treat finding itself in the Registry as unexpected and delete the Node resource, which will cause the Registry to remove all the subresources, before beginning the registration of all its current new resources starting with the Node again. See https://github.com/AMWA-TV/is-04/blob/v1.3.x/docs/Behaviour%20-%20Registration.md#node-encounters-http-200-on-first-registration

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants