Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"None" in LED backlight doesn't disable LEDs. #31

Open
MGlolenstine opened this issue Oct 24, 2023 · 2 comments
Open

"None" in LED backlight doesn't disable LEDs. #31

MGlolenstine opened this issue Oct 24, 2023 · 2 comments

Comments

@MGlolenstine
Copy link

My configuration:

❯ cat /etc/tailord/active_profile.json
{"fans":["quiet"],"leds":[{"device_name":"platform:tuxedo_keyboard","function":"kbd_backlight","profile":"default"}],"performance_profile":"performance"}⏎                                                           
~ 
❯ cat /etc/tailord/keyboard/default.json 
"None"

Whenever the computer is turned on or woken from sleep, a white LED backlight is forced on, even if I turn it off (fn+*) before putting it to sleep.

The issue also appears when leaving the computer idle for a minute or so and then touching the touchpad. It turns on the keyboard backlight.

@AaronErhardt
Copy link
Owner

The code is pretty clear. When setting the value to "None", nothing could possibly happen: https://github.com/AaronErhardt/tuxedo-rs/blob/main/tailord/src/led/runtime.rs#L49

The issue also appears when leaving the computer idle for a minute or so and then touching the touchpad. It turns on the keyboard backlight.

In this case, I assume this is done by the kernel driver. If you prefer your keyboard to always have a certain color (which can be black => no lights btw.), then the "Single" color mode would be the best. If you have another idea to "fix" the overriding of the kernel driver, let me know.

@MGlolenstine
Copy link
Author

I thought None meant no colour on LEDs. Could that be reworded to make it clearer?
I haven't thought of setting it to Black colour 😅, as I stopped at None.

I will look around and try to see if there's a way to "fix" the LEDs resetting after waking it up.
Currently, I've just set the brightness level to 0% using the keyboard shortcuts and it hasn't turned on the LEDs yet.

@MGlolenstine MGlolenstine changed the title "None" in LED backlight doesn't work correctly. "None" in LED backlight doesn't disable LEDs. Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants