Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bake keys in.. with option to override in config #57

Open
willwade opened this issue Aug 28, 2024 · 1 comment
Open

Bake keys in.. with option to override in config #57

willwade opened this issue Aug 28, 2024 · 1 comment
Milestone

Comments

@willwade
Copy link
Contributor

  • have keys in env var so at build they are available and not in Github
  • In code bake in key to code. For Azure, Google (others maybe later)
  • Config files can override this key if user asks to. It will allow play and get voices for engines. If key empty use our baked in key
  • Handle exceptions around bad keys, expired keys etc better and provide warnngs - at least in log files if needed
@willwade willwade added this to the Release v2 milestone Aug 28, 2024
willwade added a commit that referenced this issue Aug 29, 2024
@willwade
Copy link
Contributor Author

youll see I've suggested the env vars

MICROSOFT_TOKEN="token-here"
MICROSOFT_REGION="uksouth"
GOOGLE_CREDS_PATH="ttsandtranslate-7dd2e2d80d42-test.json"
GOOGLE_SA_PATH="ttsandtranslate-7dd2e2d80d42-test.json"

acerjay added a commit to acerjay/TranslateAndTTS that referenced this issue Sep 7, 2024
Capability to Load from tts-wrapper's get_voices instead of hardcoded AceCentre#43.
Fix GUI widget sizes to support touchscreen.
Multithreading capability to load voice models (Sherpa Onnx/Azure)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant