Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mutual TLS #135

Open
timgent opened this issue Jul 6, 2016 · 2 comments
Open

Mutual TLS #135

timgent opened this issue Jul 6, 2016 · 2 comments
Labels

Comments

@timgent
Copy link

timgent commented Jul 6, 2016

Would it be possible for drakov to use client certificates when it connects to the API?

@yakovkhalinsky
Copy link
Contributor

@timgent haven't done much with client TLS certs, could you describe how the process would work?

@timgent
Copy link
Author

timgent commented Jul 13, 2016

2 options:

  1. Allows the hooks to be able to add client certificate details to all requests, similar to how other auth stuff can be done (I currently have in my hooks some stuff to do an OAuth2 login, get an auth token, and use that as a header for future requests. The NodeJS Request library I think handles certs well:
    https://github.com/request/request#using-optionsagentoptions

  2. Have it as part of the spec. I'm not quite sure how this would work, would still need to configure where it should get the certificate files from. Option 1 is definitely a quicker, easier fix

What do you think? I've not dug into your code base but could possibly take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants