From 5cb833c55fbeba9cb67f0c9c6f94ea7a647b9b20 Mon Sep 17 00:00:00 2001 From: moladukes Date: Wed, 13 Oct 2021 10:05:53 -0500 Subject: [PATCH 1/3] add more s3 options for grunt-aws --- Gruntfile.js | 5 +++-- example_config.json | 4 +++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/Gruntfile.js b/Gruntfile.js index 1c9637a..33fce39 100644 --- a/Gruntfile.js +++ b/Gruntfile.js @@ -1,4 +1,4 @@ -module.exports = function(grunt) { +module.exports = function (grunt) { const sass = require('node-sass') require('load-grunt-tasks')(grunt, { pattern: ['grunt-*', 'assemble'] }) require('time-grunt')(grunt) @@ -224,11 +224,12 @@ module.exports = function(grunt) { secretAccessKey: '<%= secret.s3.secret_access_key %>', bucket: '<%= config.s3.bucket %>', region: '<%= config.s3.region %>', - overwrite: '<%= config.s3.overwrite %>', + access: '<%= config.s3.access %>' }, build: { cwd: path.images_src, src: '**', + dest: "<%= config.s3.dest %>" }, }, diff --git a/example_config.json b/example_config.json index 1b5a688..46b73d6 100644 --- a/example_config.json +++ b/example_config.json @@ -42,6 +42,8 @@ "s3": { "bucket": "", "region": "", + "dest": "/", + "access": "private", "overwrite": true } -} +} \ No newline at end of file From c2beb8d8c10f1edd854851550fd6696a666b1a3c Mon Sep 17 00:00:00 2001 From: moladukes Date: Wed, 13 Oct 2021 10:12:57 -0500 Subject: [PATCH 2/3] add overwrite back, add full permission access flag as default --- Gruntfile.js | 1 + 1 file changed, 1 insertion(+) diff --git a/Gruntfile.js b/Gruntfile.js index 33fce39..ec5e3f4 100644 --- a/Gruntfile.js +++ b/Gruntfile.js @@ -224,6 +224,7 @@ module.exports = function (grunt) { secretAccessKey: '<%= secret.s3.secret_access_key %>', bucket: '<%= config.s3.bucket %>', region: '<%= config.s3.region %>', + overwrite: '<%= config.s3.overwrite %>', access: '<%= config.s3.access %>' }, build: { From 5b508a88b8eff92d62704cdd4349853a5860dc27 Mon Sep 17 00:00:00 2001 From: moladukes Date: Wed, 13 Oct 2021 10:28:42 -0500 Subject: [PATCH 3/3] set default to public-read for s3 defaults --- example_config.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/example_config.json b/example_config.json index 46b73d6..7a445de 100644 --- a/example_config.json +++ b/example_config.json @@ -43,7 +43,7 @@ "bucket": "", "region": "", "dest": "/", - "access": "private", + "access": "public-read", "overwrite": true } } \ No newline at end of file