Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PermissionToMapper storage #31

Open
dmitrymishanov opened this issue Feb 25, 2021 · 0 comments
Open

PermissionToMapper storage #31

dmitrymishanov opened this issue Feb 25, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@dmitrymishanov
Copy link
Contributor

dmitrymishanov commented Feb 25, 2021

I think that it's not a good idea to store permissions for ORM-mapper inside a class like PermissionToMapper, because it implicitly mixes permissions for different apps if they are started inside one process (e.g. for testing purposes).

May be it would be better to make own PermissionToMapper instance for each PermissionPlugin instance or use additional nesting level to somehow identify, which app is accessing permissions now.

@dmitrymishanov dmitrymishanov added enhancement New feature or request good first issue Good for newcomers labels Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant