Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative cursor rendering idea #201

Closed
stevesims opened this issue Apr 8, 2024 · 2 comments
Closed

Alternative cursor rendering idea #201

stevesims opened this issue Apr 8, 2024 · 2 comments

Comments

@stevesims
Copy link
Contributor

Rather than the current XOR based cursor rendering, we could render the cursor in a similar manner to sprites - copy the background and then draw a rectangle when showing, and paste the background when hiding. doing this the cursor will always be able to render, and will always be shown in the current text foreground colour.

going down this route we could also, potentially, add support for using a bitmap as a cursor

(part of the "problem" with the existing cursor rendering system is that the routine that draws the cursor neither knows or really cares whether it's showing or hiding the cursor. we separately track a binary to indicate whether the cursor is showing or is hidden, but the drawing routine simply doesn't care)

@lennart-benschop
Copy link
Contributor

The cursor will then be completely invisible when it is over a rectangle that is completely in the foreground colour. For example a space that was drawn in reverse video.

@stevesims
Copy link
Contributor Author

Closing this - the current cursor rendering seems to be completely adequate and up to the task. as pointed out this idea itself is flawed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants