Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

audit and normalize error handling #10968

Open
turadg opened this issue Feb 7, 2025 · 0 comments
Open

audit and normalize error handling #10968

turadg opened this issue Feb 7, 2025 · 0 comments
Assignees
@turadg @dckc
Labels
enhancement New feature or request needs-design test

Comments

@turadg
Copy link
Member

turadg commented Feb 7, 2025

What is the Problem Being Solved?

The fast-usdc contract's error handling has accreted incrementally, leading to multiple patterns. Some throw synchronously, some promises. Some are caught, some promises are explicitly unhandled. Some silent failures,

Description of the Design

Look over the contract for all calls that can error and confirm that they are handled/logged correctly.

Security Considerations

Scaling Considerations

Test Plan

Upgrade Considerations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turadg turadg

@dckc dckc

Labels
enhancement New feature or request needs-design test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@turadg @dckc