-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Idea] GitHub action for testing urls #241
Comments
@jashapiro , is this something we could/should add to |
I think adding it to the build stage is too late. I would prefer it run at the same time as spell checking. I am not sure how that particular action handles local links (i.e. if a user links to an html file that is not yet on That actually brings up another issue which is that we should consider updating all links to |
I am unsure. My guess is it probably doesn't do well. Would relative links work if users are looking at the Rmd locally? (Also would users want to access links while on the Rmd locally, my thought is |
Relative links should work locally. They are a very common way to write markdown links. |
This was something I hadn't considered: I was thinking about local development, not end users downloading a single |
There's a lot of links everywhere in the material for this repo. I would hate for broken links to slip through to be found by users.
https://github.com/marketplace/actions/url-checker
This says it's for testing markdown links, but I think? It might work for Rmds too?
Obviously, this wouldn't catch incorrect links: one's that work but aren't going to the right place according to the context, but if its simple enough to implement I think it would be a nice add.
The text was updated successfully, but these errors were encountered: