Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show more states besides processing on the one-click experiment download #888

Open
arielsvn opened this issue Apr 1, 2020 · 1 comment

Comments

@arielsvn
Copy link
Contributor

arielsvn commented Apr 1, 2020

Following up discussion in #886 (comment)

This is what I was referring to:

2020-04-01 15 24 03

To reproduce you can do:

  1. Download one experiment using the one-click download button
  2. Wait until you receive the email so that the dataset is already processed
  3. Refresh the page

Since the dataset is already processed we don't show anything to the user.

@dvenprasad should we have a "Dataset Processed" badge too? We could have it link to the dataset page where users can download their dataset.

@davidsmejia
Copy link
Collaborator

davidsmejia commented Apr 1, 2020

I think the lightest lift would be adding another clause to to the useExperimentDataset to not delete until the dataset is no longer downloadable.

components/DownloadExperiment.js:60

      if (refreshedDataset.is_processed && !refreshedDataset.is_downloadable) {
        setDatasetToLocalStorage({ ...emptyDataset });
      } else if (!dataset.id) {
        setDatasetToLocalStorage({ ...refreshedDataset });
      }

And then we can do whatever with that information in the ProcessingExperiment component to show that it is done and can be downloaded from /datasets/dataset-id-number since it only displays with the entire dataset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants