GA implementation review

[davidsmejia]

Context

I was reviewing the open GA issues and wanted to comment on more than one of them so I am opening this issue to ensure that these notes are addressed in each of them. Note this is not the entire review and each PR may have their own changes or explanations requested.

Problem or idea

We should ensure that the current GA PRs adhere to the following:

• No static strings or values are defined outside of the function.
• No data is pre-formatted before passing to a gtag.specificTrackingEventName function.
• Every tracked metric will have a unique function. Data will be unformatted and be mutated in the function.

If two or more functions are very similar but do not track the same event, write functionality that can be shared between them but distinguish them by their function name.

Solution or next step

• Ensure all open PRs related to GA adhere to the above principles

[davidsmejia]

Lets start with the first 5 start with the oldest and I will review those and we can move forward from there.

[nozomione]

Epic: GA4 Integration

This issue is to revise the following PRs for the GA custom events.

Step 1: Refactor the gtag script and adjust implementation of the first 5 PRs in chronological order for code review:

• 303 - Implement GA4 custom events script #321 (this is Gtag custom event script that is used in PRs below)
  • 315 - Add GA custom event for Dataset to DOM elements  #322
  • 316 - Add GA custom event for Compendia to DOM elements #323
  • 317 - Add GA custom event for Search to DOM elements  #324
  • 318 - Add GA custom event for Email Subscription to DOM elements #325
  • 319 - Add GA custom event for Links to DOM elements #326
  • 🔔 David via Slack

Step 2: Once the 1st step is completed, refactor the gtag script for the remaining PR:

• 303 - Implement GA4 custom events script #321 (Gtag custom event script that is used in PR below)
  • 320 - Add GA custom event for Internal navigation to DOM elements #327

[nozomione]

Completed the items listed.