Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

386 - Refactor MoveToDatasetButton / MoveToDatasetModal components #435

Open
wants to merge 12 commits into
base: dev
Choose a base branch
from

Conversation

nozomione
Copy link
Member

@nozomione nozomione commented Jan 6, 2025

Issue Number

Closes #386

Base branch: PR #421

Purpose/Implementation Notes

I've used an early return to handle the case of no samples in My Dataset, and optimized the action methods (append, replace) of the "Move to Dataset" button.

Types of changes

  • Refactor (addresses code organization and design mentioned in corresponding issue)

Functional tests

N/A

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Screenshots

N/A

…ion in RefinebioContext (during the initial load of the application - replacing the useToken hook) ,and adjusted the other hooks that utilize token
…er viist without activation if it doesn't exist) and use the side effect to sync the token state with acceptedTerms in RefinebioContext, remove the token generation logic from consumer hooks, rename the prop name 'params' to 'body' in interface s methods
… the usage of token/applyAcceptedTerms), and use the token state in hooks instesd (added a new hook useTriggerSubmit - decuple the useEffect until adding conetxt/hook for file download and download options etc)
… accordingly, use this new hook in RefeinbioContext provider and add waitForToken method, use waitForToken in useDatasetManager
… to 'endpoint' for clarity, (minor) remove obsolete interfaces from the api folder
…set in MoveToDatasetButton, rename state/variables for clarity, clean up props, optimize the action methods for the MoveToDatasetModal
@nozomione nozomione self-assigned this Jan 6, 2025
Copy link

vercel bot commented Jan 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
refinebio-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 11:35pm

@nozomione nozomione linked an issue Jan 6, 2025 that may be closed by this pull request
@nozomione nozomione requested review from davidsmejia and removed request for davidsmejia January 6, 2025 20:28
Base automatically changed from nozomione/413-update-token-validation-flow to dev January 8, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor MoveToDatasetButton / MoveToDatasetModal components
1 participant