-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
428 - Update startProcessingDataset to accept formatted data from caller Formik components #431
base: dev
Are you sure you want to change the base?
Conversation
…ion in RefinebioContext (during the initial load of the application - replacing the useToken hook) ,and adjusted the other hooks that utilize token
…er viist without activation if it doesn't exist) and use the side effect to sync the token state with acceptedTerms in RefinebioContext, remove the token generation logic from consumer hooks, rename the prop name 'params' to 'body' in interface s methods
…of use checkbox visibility)
… the usage of token/applyAcceptedTerms), and use the token state in hooks instesd (added a new hook useTriggerSubmit - decuple the useEffect until adding conetxt/hook for file download and download options etc)
… accordingly, use this new hook in RefeinbioContext provider and add waitForToken method, use waitForToken in useDatasetManager
…eDatasetManager's startProcessingDataset method
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -22,11 +22,10 @@ export const SignUpBlock = () => { | |||
<FixedContainer align="center"> | |||
<Formik | |||
initialValues={{ | |||
emailAddress: '' | |||
email_address: '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please note that this field has also been renamed for consistency.
.string() | ||
.email('Please enter a vaild email') | ||
.required('Please enter your email address'), | ||
termsOfUse: yup | ||
terms: yup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've also shortened the termsOfUse
field to terms
.
…omponents-for-start-processing-dataset
Issue Number
Closes #428
Base branch: PR #421
Purpose/Implementation Notes
I've updated the caller Formik components to prepare the download options for the
startProcessingDataset
method.Types of changes
Functional tests
N/A
Checklist
Screenshots
N/A