Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

428 - Update startProcessingDataset to accept formatted data from caller Formik components #431

Open
wants to merge 13 commits into
base: dev
Choose a base branch
from

Conversation

nozomione
Copy link
Member

Issue Number

Closes #428

Base branch: PR #421

Purpose/Implementation Notes

I've updated the caller Formik components to prepare the download options for the startProcessingDataset method.

Types of changes

  • Refactor (addresses code organization and design mentioned in corresponding issue)

Functional tests

N/A

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Screenshots

N/A

…ion in RefinebioContext (during the initial load of the application - replacing the useToken hook) ,and adjusted the other hooks that utilize token
…er viist without activation if it doesn't exist) and use the side effect to sync the token state with acceptedTerms in RefinebioContext, remove the token generation logic from consumer hooks, rename the prop name 'params' to 'body' in interface s methods
… the usage of token/applyAcceptedTerms), and use the token state in hooks instesd (added a new hook useTriggerSubmit - decuple the useEffect until adding conetxt/hook for file download and download options etc)
… accordingly, use this new hook in RefeinbioContext provider and add waitForToken method, use waitForToken in useDatasetManager
…eDatasetManager's startProcessingDataset method
@nozomione nozomione self-assigned this Dec 20, 2024
Copy link

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
refinebio-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 11:14pm

@nozomione nozomione marked this pull request as ready for review December 20, 2024 14:18
@@ -22,11 +22,10 @@ export const SignUpBlock = () => {
<FixedContainer align="center">
<Formik
initialValues={{
emailAddress: ''
email_address: ''
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that this field has also been renamed for consistency.

.string()
.email('Please enter a vaild email')
.required('Please enter your email address'),
termsOfUse: yup
terms: yup
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also shortened the termsOfUse field to terms.

Base automatically changed from nozomione/413-update-token-validation-flow to dev January 8, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update startProcessingDataset to accept formatted data from caller Formik components
1 participant