From a834306637758725b49daaf9cdbaacc6896327eb Mon Sep 17 00:00:00 2001 From: openhands Date: Thu, 13 Feb 2025 23:45:19 +0000 Subject: [PATCH 1/2] fix: Simplify nested f-string to fix pydoc-markdown parsing --- openhands/resolver/interfaces/gitlab.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/openhands/resolver/interfaces/gitlab.py b/openhands/resolver/interfaces/gitlab.py index 0b2937170910..5c2bb5313650 100644 --- a/openhands/resolver/interfaces/gitlab.py +++ b/openhands/resolver/interfaces/gitlab.py @@ -33,7 +33,8 @@ def get_headers(self): } def get_base_url(self): - return f'https://gitlab.com/api/v4/projects/{quote(f'{self.owner}/{self.repo}', safe="")}' + project_path = quote(f'{self.owner}/{self.repo}', safe="") + return f'https://gitlab.com/api/v4/projects/{project_path}' def get_authorize_url(self): return f'https://{self.username}:{self.token}@gitlab.com/' From 5b9d7908a1a1d139044a841c32dd16d615a05ddc Mon Sep 17 00:00:00 2001 From: openhands Date: Thu, 13 Feb 2025 23:46:44 +0000 Subject: [PATCH 2/2] refactor: Simplify more f-string expressions for better readability --- openhands/resolver/interfaces/gitlab.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/openhands/resolver/interfaces/gitlab.py b/openhands/resolver/interfaces/gitlab.py index 5c2bb5313650..52661d93032d 100644 --- a/openhands/resolver/interfaces/gitlab.py +++ b/openhands/resolver/interfaces/gitlab.py @@ -46,9 +46,9 @@ def get_download_url(self): return f'{self.base_url}/issues' def get_clone_url(self): - username_and_token = ( - f'{self.username}:{self.token}' if self.username else f'{self.token}' - ) + username_and_token = self.token + if self.username: + username_and_token = f'{self.username}:{self.token}' return f'https://{username_and_token}@gitlab.com/{self.owner}/{self.repo}.git' def get_graphql_url(self): @@ -361,7 +361,8 @@ def download_pr_metadata( } """ - variables = {'projectPath': f'{self.owner}/{self.repo}', 'pr': f'{pull_number}'} + project_path = f'{self.owner}/{self.repo}' + variables = {'projectPath': project_path, 'pr': str(pull_number)} response = requests.post( self.get_graphql_url(),