Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0] Edge case with light and lenses attached together #1139

Open
tiffanyona opened this issue Nov 1, 2024 · 2 comments · May be fixed by #1240
Open

[2.0] Edge case with light and lenses attached together #1139

tiffanyona opened this issue Nov 1, 2024 · 2 comments · May be fixed by #1240
Assignees
Labels
breaking Breaking changes

Comments

@tiffanyona
Copy link

Is your feature request related to a problem? Please describe.
Current IR lights are connected to specific lenses. There is no way to stablish a relationship between the IR and the corresponding lens.

Describe the solution you'd like
Perhaps stablishing a LightAssembly since these parts are also connected together and work as a unit?

Describe alternatives you've considered
ATM, I am creating separate instances for each of the IR lights and lenses and just following a similar naming convention that allows me to associate them posthoc. For instance, Face IR and Face IR lens names.

@saskiad saskiad added this to the v2.0 milestone Jan 15, 2025
@dbirman dbirman changed the title Edge case with light and lenses attached together [2.0] Edge case with light and lenses attached together Jan 15, 2025
@dbirman dbirman added the breaking Breaking changes label Jan 15, 2025
@dbirman dbirman linked a pull request Jan 16, 2025 that will close this issue
@dbirman
Copy link
Member

dbirman commented Jan 16, 2025

@tiffanyona do you want any other devices available or just lens + light source?

@tiffanyona
Copy link
Author

Not from the top of my head, the lens + light should be what I had missing. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment