Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0] Background strain needs to be tethered to species #1214

Open
saskiad opened this issue Jan 7, 2025 · 3 comments
Open

[2.0] Background strain needs to be tethered to species #1214

saskiad opened this issue Jan 7, 2025 · 3 comments
Assignees
Labels
breaking Breaking changes

Comments

@saskiad
Copy link
Collaborator

saskiad commented Jan 7, 2025

Is your feature request related to a problem? Please describe.
Strains are species specific. Our current enum of strains are unique to mouse.

Describe the solution you'd like
I'm not entirely sure the correct way to implement this. We currently have a short enum of 2 mouse strains. We either need to be able to point this to different enums for different species, or have a single list but know which ones are for which species and have a validation step to make sure species and strain match?

And we should probably move the list(s) of strains to the models repo?

@saskiad saskiad added this to the v2.0 milestone Jan 7, 2025
@dbirman
Copy link
Member

dbirman commented Jan 7, 2025

One option would be to replace species in the models repo with strain, so the species stays attached to the strain. In subject.py if someone provides a strain we can auto-populate species (or at least validate that it matches) and if someone skips the strain we still require the species.

@saskiad
Copy link
Collaborator Author

saskiad commented Jan 8, 2025

I think something along these lines makes sense.

@dbirman
Copy link
Member

dbirman commented Jan 8, 2025

@dbirman dbirman added the breaking Breaking changes label Jan 15, 2025
@dbirman dbirman self-assigned this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking changes
Projects
None yet
Development

No branches or pull requests

2 participants