Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0] Request for composability in session (possibly rig) #1218

Open
dbirman opened this issue Jan 8, 2025 · 1 comment
Open

[2.0] Request for composability in session (possibly rig) #1218

dbirman opened this issue Jan 8, 2025 · 1 comment
Assignees
Labels
breaking Breaking changes

Comments

@dbirman
Copy link
Member

dbirman commented Jan 8, 2025

Is your feature request related to a problem? Please describe.
Users request that we make it possible to combine two session files and possibly two rig files to make maintenance easier, i.e. given valid session_behavior.json and session_ephys.json we make it possible to do session = session_behavior + session_ephys

Describe the solution you'd like
Override __add__ to combine data streams and validate that other fields are matched

@dbirman dbirman added this to the v2.0 milestone Jan 9, 2025
@dbirman
Copy link
Member Author

dbirman commented Jan 9, 2025

Convert Stream to List[Union[]] for this

@dbirman dbirman added the breaking Breaking changes label Jan 15, 2025
@dbirman dbirman self-assigned this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking changes
Projects
None yet
Development

No branches or pull requests

1 participant