From c8e68aa17b9115c1c2914923282a0c7750601a48 Mon Sep 17 00:00:00 2001 From: Dan Birman Date: Thu, 9 Jan 2025 10:43:54 -0800 Subject: [PATCH] refactor: replace create_unit_with_value with field/field_unit --- src/aind_data_schema/core/procedures.py | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/aind_data_schema/core/procedures.py b/src/aind_data_schema/core/procedures.py index 4abf627f4..555b5fc41 100644 --- a/src/aind_data_schema/core/procedures.py +++ b/src/aind_data_schema/core/procedures.py @@ -18,7 +18,6 @@ TimeUnit, UnitlessUnit, VolumeUnit, - create_unit_with_value, ) from pydantic import Field, SkipValidation, field_serializer, field_validator, model_validator from pydantic_core.core_schema import ValidationInfo @@ -170,10 +169,8 @@ class Stain(Reagent): """Description of a non-oligo probe stain""" stain_type: StainType = Field(..., title="Stain type") - # TODO: It might be easier to maintain to avoid dynamic model creation - concentration: create_unit_with_value("concentration", Decimal, ConcentrationUnit, ConcentrationUnit.UM) = Field( - ..., title="Concentration (uM)" - ) + concentration: Decimal = Field(..., title="Concentration") + concentration_unit: ConcentrationUnit = Field(default=ConcentrationUnit.UM, title="Concentration unit") class HybridizationChainReaction(AindModel):