You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I currently use "Picker" with minPanel prop to allow to display the component to select only years or months.
I have 2 issues with the actual implementation :
I cannot close the panel when my selection is done (closeOnSelectDay prop works only if dayPanel is the current one)
onChange is triggered each time I display a panel, even if the user does not make selection at all (ex navigatiin in years)
I propose to take care of the minPanel option to trigger change only when the min panel is the current one, and evaluate "closeOnSelect" under this condition.
Below is a diff of a possible implementation.
Are you open to a PR about this ?
Hi @mvachette
I think this repository/package will not be active any more.
Please use this improved package and if that issue was still exist, report that issue to the improved package repo and help us making it better than before.
I currently use "Picker" with
minPanel
prop to allow to display the component to select only years or months.I have 2 issues with the actual implementation :
closeOnSelectDay
prop works only if dayPanel is the current one)onChange
is triggered each time I display a panel, even if the user does not make selection at all (ex navigatiin in years)I propose to take care of the
minPanel
option to trigger change only when the min panel is the current one, and evaluate "closeOnSelect" under this condition.Below is a diff of a possible implementation.
Are you open to a PR about this ?
The text was updated successfully, but these errors were encountered: