Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation files have old href references #744

Open
bennyvasquez opened this issue Jan 23, 2025 · 0 comments
Open

Translation files have old href references #744

bennyvasquez opened this issue Jan 23, 2025 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@bennyvasquez
Copy link
Member

It looks like these lines are mistakenly included in some of our translation files. As far as I can tell, they aren't used on the website and aren't included in the English files anymore, but they're lingering in non-english translation files and can be removed:

:almawww $ grep "a href" ./i18n/ar.json 
    "<a href=\"%(intro_link)s\">Introduce yourself</a> or join one of the topical channels below to find out more!": "<a href=\"%(intro_link)s\">عرف بنفسك</a> او انضم إلى واحدة من القنوات الموضوعية التالية لاكتشاف المزيد!",
    "The beating heart of ELevate is the <a href=\"%(pes_link)s\">Package Evolution Service</a> (PES) which allows you to download, customize and even submit new data sets for packages. Users and maintainers can both utilize the PES to help make migrations smooth and easy.": "القلب النابض لـ ELevate هو<a href=\"%(pes_link)s\">خدمة تطوير الحزمة</a>(PES)الذي يسمح لك بتنزيل مجموعات بيانات جديدة للحزم وتخصيصها وحتى إرسالها. يمكن للمستخدمين والمشرفين على حد سواء استخدام PES للمساعدة في جعل عمليات الترحيل سلسة وسهلة.",
    "First join us at <a href=\"%(chat_link)s\">#migration</a> Mattermost channel. You can find the tool code here: <a href=\"%(github_link)s\">%(github_link)s</a> and you can add/edit/interact with package metadata at <a href=\"%(pes_link)s\">%(pes_link)s</a>.": "انضم إلينا أولاً في<a href=\"%(chat_link)s\">#migration</a>القناة الأكثر أهمية. يمكنك العثور على الأداة الكود هنا:<a href=\"%(github_link)s\">%(github_link)s</a> ويمكنك إضافة / تعديل / التفاعل مع البيانات الوصفية للحزمة على<a href=\"%(pes_link)s\">%(pes_link)s</a>.",
    "Switching distributions is usually costly and time-consuming, but that’s not the case when switching from CentOS and other RHEL&reg; derivatives to AlmaLinux OS. Switching is easy - <a href=\"%(migrate_link)s\">read how.</a>": "عادةً ما يكون تبديل التوزيعات مكلفًا ويستغرق وقتًا طويلاً ، ولكن هذا ليس هو الحال عند التبديل من CentOS وغيرهاRHEL&reg; مشتقات لنظام AlmaLinux OS. التبديل سهل -<a href=\"%(migrate_link)s\">read how.</a>",
    "Currently, ELevate project supports the following migration directions: * - migration to CentOS Stream 9 is currently in process and will be available later. ** - migration to Oracle Linux 9 is available with the <a href=\"https://blogs.oracle.com/linux/post/upgrade-oracle-linux-8-to-oracle-linux-9-using-leapp\">Oracle Leapp utility</a> and will not be supported by ELevate project.": "يدعم مشروع ELevate حاليا هذه الاتجاهات للترحيل: * - الترحيل من CentOS Stream 9 حاليا قيد العمل وسيُتاح لاحقًا. ** - الترحيل من Oracle Linux 9 متاح مع أداة <a href=\"https://blogs.oracle.com/linux/post/upgrade-oracle-linux-8-to-oracle-linux-9-using-leapp\">Oracle Leapp utility</a> ولن يدعمها مشروع ELevate.",
    "The official AlmaLinux OS images are available on \"}}<a href=\"https://cloudmarketplace.oracle.com/marketplace/en_US/partners/125035508\">{{ i18n \"Oracle Cloud Marketplace": "<html>الصور الرسمية لنظام التشغيل AlmaLinux متاحة على \"}} <a href=\"https://cloudmarketplace.oracle.com/marketplace/en_US/partners/125035508\">{{ i18n \"Oracle Cloud Marketplace</a>",
    "More information about AlmaLinux OpenNebula images and verification guidelines are available on the \"}}<a href=\"https://wiki.almalinux.org/cloud/OpenNebula.html\">{{ i18n \"AlmaLinux OpenNebula Wiki Page": "<html>مزيد من المعلومات حول صور AlmaLinux OpenNebula وإرشادات التحقق متاحة على \"}} <a href=\"https://wiki.almalinux.org/cloud/OpenNebula.html\">{{ i18n \"AlmaLinux OpenNebula Wiki Page</a>",

They're in all of our existing translation files:

elita:i18n bennyvasquez$ grep -Rl "a href" *
ar.json
ca.json
cs.json
da.json
de.json
el.json
es.json
fa.json
fi.json
fr.json
he.json
hu.json
it.json
ja.json
ko.json
lt.json
lv.json
pl.json
pt-br.json
pt.json
ru.json
sk.json
sv.json
tr.json
uk.json
zh-hans.json
elita:i18n bennyvasquez$

These lines should be removed from these files and re-committed to the repo. We should also consider if it's worth expanding find_missing_i18n_strings.py to look for mis-matches between files.
@bennyvasquez bennyvasquez added bug Something isn't working good first issue Good for newcomers labels Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bennyvasquez