Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use @inherits in roxygen to simplify documentation #28

Open
AngusMcLure opened this issue Dec 5, 2023 · 2 comments
Open

Use @inherits in roxygen to simplify documentation #28

AngusMcLure opened this issue Dec 5, 2023 · 2 comments
Assignees
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Milestone

Comments

@AngusMcLure
Copy link
Owner

We can use @inherits to simplify the documentation of functions like design_effect and optimise_X since these functions reuse many of the arguments used in fi_pool and fi_pool_cluster. In general I think the @inherits should follow the dependency graph, i.e. document the parameters in the lowest (exported) function that uses that argument, and then use @inherits to propagate them through the docs

This will ensure consistent documentation across function and reduce the number of places we need to edit if we want to change something in the docs.

Not urgent, but helpful

@fredjaya
Copy link
Collaborator

fredjaya commented Dec 5, 2023

Agree! Planning on doing it in the next round of improving documentation 😎

- [ ] Revise documentation so majority @inheritParams fi_pool

@AngusMcLure
Copy link
Owner Author

Awesome!

@fredjaya fredjaya added the documentation Improvements or additions to documentation label Dec 5, 2023
@fredjaya fredjaya added this to the upcoming docs milestone Dec 5, 2023
@fredjaya fredjaya added the good first issue Good for newcomers label Jun 28, 2024
fredjaya added a commit that referenced this issue Jul 9, 2024
Separated existing functions with new method, method exports, and better
inheritance of params etc. #28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants