Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Apicurito to latest Studio editor component (automate this?) #144

Open
colvinco opened this issue Jan 24, 2022 · 2 comments
Open
Assignees

Comments

@colvinco
Copy link

Hello. I didn't find any other issues about this, other than Apicurio/apicurio-studio#1111 which is tangentially relevant.

Here's a minimal bit of an example petstore spec, which has a deprecated GET /pet/findByTags on it.

openapi: 3.0.2
info:
    title: Swagger Petstore
    version: 1.0.6
paths:
    /pet/findByTags:
        get:
            tags:
                - pet
            responses:
                '204':
                    description: Nothing
            deprecated: true
            operationId: findPetsByTags
            summary: Finds Pets by tags
            description: 'Multiple tags can be provided with comma separated strings. Use tag1, tag2, tag3 for testing.'
components: {}

In Apicurio Studio the deprecation control is present
image

In Apicurito there's no control or any mention of the deprecation
image

@EricWittmann
Copy link
Member

Ah thanks. This is just because Apicurito hasn't been updated in quite some time (with the latest editor control exported by Studio). I'll see if I can carve out some time to update Apicurito with the latest.

@EricWittmann EricWittmann changed the title Deprecated operation dropdown control doesn't appear in Apicurito Upgrade Apicurito to latest Studio editor component (automate this?) Feb 3, 2022
@EricWittmann EricWittmann self-assigned this Mar 3, 2022
@EricWittmann
Copy link
Member

Turns out this is actually a bit harder than I thought it would be. The Apicurio Studio UI has been upgraded to a much more recent version of Angular, and this would need to follow. I have it mostly working with a bunch of upgraded dependencies, but there are still some font issues and other minor problems. It may take a bit of time to iron out the details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@EricWittmann @colvinco and others