Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Originals: Controls buggy on "Tumblr TV" #1425

Open
marcustyphoon opened this issue Mar 27, 2024 · 0 comments
Open

Show Originals: Controls buggy on "Tumblr TV" #1425

marcustyphoon opened this issue Mar 27, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@marcustyphoon
Copy link
Collaborator

Platform

MacOS 14.3.1

Browser

Chrome 123.0.6312.59

Addon version

v0.23.4

Details

When switching back and forth between the "following" and "tumblr tv" dashboard tabs, the Show Originals controls element sometimes persists over "tumblr tv." Presumably this is due to the code I wrote to update it firing on new posts, and that dashboard tab not having anything that counts as a post.

I'll deal with this... somehow at some point. Maybe using the navigation hook? Querying for the timeline itself being added? Who knows. It's very minor unless it applies to more than just this scenario.

@marcustyphoon marcustyphoon added the bug Something isn't working label Mar 27, 2024
@marcustyphoon marcustyphoon self-assigned this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant