Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Firefox on-update cleanup #1616

Open
marcustyphoon opened this issue Sep 16, 2024 · 0 comments
Open

Improve Firefox on-update cleanup #1616

marcustyphoon opened this issue Sep 16, 2024 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@marcustyphoon
Copy link
Collaborator

Concept

I wasn't thinking of modifying runScript at all; I was thinking of modifying init to detect if XKit has already run, then calling destroyScript for each enabled script if it has (and calling $('style.xkit').remove()) before continuing with the usual .forEach(runScript).

To achieve the desired effect from this, each feature's clean() method will need to be slightly adjusted to not rely on references to elements in memory, and tested for if it errors out before its main() is run (I'm looking at you, Old Sidebar in XKit 7). Beyond that, it's just a matter of making the utility modules clean themselves up like the sidebar/meatballs utils or repetition-prevent themselves like the remixicon util.

Originally posted by @AprilSylph in #451 (comment)

@marcustyphoon marcustyphoon added enhancement New feature or request help wanted Extra attention is needed labels Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant