Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks: "Make following/mutuals indicators on notifications more subtle" option is broken #1649

Open
AprilSylph opened this issue Nov 12, 2024 · 3 comments · May be fixed by #1654
Open

Tweaks: "Make following/mutuals indicators on notifications more subtle" option is broken #1649

AprilSylph opened this issue Nov 12, 2024 · 3 comments · May be fixed by #1654
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@AprilSylph
Copy link
Owner

Platform

Steam Deck

Browser

Firefox 132.0.1 (64-bit)

Addon version

v1.0.4

Details

Activity items are using a new label component that the "Make following/mutuals indicators on notifications more subtle" tweak does not affect, seemingly in any capacity.

@AprilSylph AprilSylph added bug Something isn't working help wanted Extra attention is needed labels Nov 12, 2024
@marcustyphoon
Copy link
Collaborator

marcustyphoon commented Nov 12, 2024

Me: "Oh no, they look the same, how could my code have broken?"
The element: *has no icon, rendering the concept of the tweak pointless*
Me: "Oh."

I guess we can add an icon, then collapse to it.

Related: the communities members page has the same element; implementing this for activity notifications would allow it to be implemented there as well.

@AprilSylph

This comment was marked as off-topic.

@marcustyphoon

This comment was marked as off-topic.

@marcustyphoon marcustyphoon pinned this issue Nov 28, 2024
@marcustyphoon marcustyphoon linked a pull request Nov 28, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants