Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node ID occasionally disappears [MAKE LABEL POSITIONS EDITABLE] #41

Open
tatsuro-ueda opened this issue Dec 22, 2018 · 14 comments
Open
Assignees
Labels
bug Something isn't working enhancement New feature or request
Milestone

Comments

@tatsuro-ueda
Copy link

Maybe when a focus returns to the node, and when the node was just moved while zoom outing

@ArsMasiuk
Copy link
Owner

hello,
this could happen if some ids overlay one another.
in this case, one of them will be hidden to avoid wasting the space.
Maybe better solution would be to try to layout such ids differently...

Do you need to see all the ids at a time?

@tatsuro-ueda
Copy link
Author

OK, I get it. You mean that if density of node is very high, too many labels are shown and the appearance of graph isn't good.

I couldn't know this rule and felt that something doesn't work correctly. Maybe this is a subject of user experience. I suggest to add "show overlapped labels" to "view" menu. How about this?

@ArsMasiuk ArsMasiuk added the enhancement New feature or request label Dec 28, 2018
@ArsMasiuk
Copy link
Owner

Exactly. The labels become not readable when they overlap.
A quick solution would be, as you suggested, to add the menu entry "show overlapped labels".
A more sophisticated one would be, to introduce a kind of automatical "smart" layouting. I.e. shifting overlapping labels to optimize the space. But it is a quite complex task for now :(

@tatsuro-ueda
Copy link
Author

tatsuro-ueda commented Dec 30, 2018

I agree with you. It is very complex. I have heard that there is a library of labeling on a digital map. It might be better to use that.

Although smart layouting is not necessary immediately, I'd like to drag (move) labels. I show you a following example. Two nodes which are at the same height vertically have to be arranged far from each other enough to show their entire labels. Sometimes I'd like to put a label upper or upper right-hand (or other sides) of a node.

_ g__my drive_office_190331_2018 12 23 holomagnet5 gexf - qt visual graph editor 0 5 1 64bit 2018-12-30 11 28 03

@tatsuro-ueda
Copy link
Author

Should I create a new issue of this subject?

@tatsuro-ueda
Copy link
Author

tatsuro-ueda commented Dec 30, 2018

For the moment, it's also not necessary to drag a label. It's enough to select the label position from options as "downer left-hand" "downer" "downer right-hand" "left" "center" "right" "upper left-hand" "upper" "upper right-hand". That might be better from a viewpoint of simplicity.

@ArsMasiuk
Copy link
Owner

Ok, I got this. Yes, something like specifying the label position would be enough for the quick solution (like with ports).
I think that a separate ticket is not necessary so we can stay on this one.

@tatsuro-ueda
Copy link
Author

All right. Anyway, I'm afraid that I might be a slave driver since it is in your vacation. (*_*) (Is this English correct?)

@ArsMasiuk
Copy link
Owner

Oh, please don't excuse, your English is very good (and ways better than mine) :)
And I really appreciate all your comments because they are helping me drastically to improve the application's ux and logic. So I see your feedback as a very cooperative job, and I glad that my app is working :)

@tatsuro-ueda
Copy link
Author

I'm happy to hear that. I hope your success of development.

@ArsMasiuk ArsMasiuk added this to the 0.6 milestone Jan 6, 2019
@ArsMasiuk ArsMasiuk changed the title Node ID occasionally disappears Node ID occasionally disappears [MAKE LABEL POSITIONS EDITABLE] Jan 10, 2019
@ArsMasiuk
Copy link
Owner

An option is needed to let the label's text be always sticked to the bottom of the node (i.e. do not try to fit it automatically into the node box).

@ArsMasiuk ArsMasiuk pinned this issue Jul 9, 2020
@ArsMasiuk ArsMasiuk modified the milestones: 0.6, 0.7 Aug 3, 2020
@ArsMasiuk
Copy link
Owner

A side bug: if node size > 15 then the text is drawn centred and sometimes disappears.

@ArsMasiuk ArsMasiuk added the bug Something isn't working label Aug 29, 2021
ArsMasiuk added a commit that referenced this issue Dec 8, 2021
@ArsMasiuk
Copy link
Owner

For nodes, now it is possible to set the label position from the list.

ArsMasiuk added a commit that referenced this issue Jan 8, 2022
@ArsMasiuk ArsMasiuk self-assigned this Feb 6, 2022
@ArsMasiuk
Copy link
Owner

Icons added.
Not sure what to do with edge labels yet...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants