The fix for issue #78 is not complete #98
Comments
|
@xybei Sorry for the late reply - are you able to provide a sample document that we can test against? |
|
@jamie-lemon Here is a sample file: test-search.pdf This is a GIF I recorded to reproduce the problem. If you want to reproduce the problem, you need to use a Chinese input method (such as the Microsoft Pinyin input method in Windows). This problem is caused by changing the |
Addresses issues #78 & #98 A listener for search input doesn't work well with language input methods which convert words into kanji or Chinese characters. This adds a dedicated search button and ensures that the previous & next buttons are shown and hidden as required. It also prints out better syntax for the search information.
* Addresses issues ArtifexSoftware#78 & ArtifexSoftware#98 Fix the issue where the search results on the current page would be skipped when clicking the "Next" search button for the first time. Improve the search experience for the Chinese input method. * Add an Enter key handler for the search input. Enter: search "Next" Shift + Enter: search "Prev" * Display page number based on 1
* Addresses issues ArtifexSoftware#78 & ArtifexSoftware#98 Fix the issue where the search results on the current page would be skipped when clicking the "Next" search button for the first time. Improve the search experience for the Chinese input method. * Add an Enter key handler for the search input. Enter: search "Next" Shift + Enter: search "Prev" * Display page number based on 1 Signed-off-by: xybei <[email protected]>
|
Thank you @jamie-lemon. Adding a "Search" button is an innovative idea, but there is a small flaw in my test. If the target word only appears in the pages before the current page, clicking "Search" cannot trigger the display of "Prev" or "Next", and thus cannot search for the previous words. Considering that search boxes usually use two buttons, I submitted a pull request #112. Please see if it is acceptable? |
|
Sure - I will check it out and get back to you. 👍 |
* Improve search functionality * Addresses issues #78 & #98 Fix the issue where the search results on the current page would be skipped when clicking the "Next" search button for the first time. Improve the search experience for the Chinese input method. * Add an Enter key handler for the search input. Enter: search "Next" Shift + Enter: search "Prev" * Display page number based on 1 Signed-off-by: xybei <[email protected]> * Replace the Prev & Next button text with the language agnostic symbols '<' and '>' Signed-off-by: xybei <[email protected]> --------- Signed-off-by: xybei <[email protected]>
|
This issue has been addressed by pull request #112 |
The fix for issue #78 does not seem to be very friendly to Chinese characters.
When I input and search for Chinese, I need to type several letters
"zhong"to enter the Chinese character"中"(for example, it appears on the first page), but when I type the first letter"z"(it appears on the fifth page), theinputevent will be triggered and the search will be started, the view will jump to the fifth page. Even if I enter the complete character"中"later, the character"中"on the first page has been skipped.The text was updated successfully, but these errors were encountered: