-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for multiple imageUrls for a single day's strip #141
Comments
Ok, so I assumed one image per day in my data model: I'd accept a PR to switch To transform the existing JSON, I recommend writing a migration and running comicsrss.com/_generator/bin.js Lines 13 to 16 in b0b86a8
The migration would looks something like: function migration([ id, seriesObject ]) {
seriesObject.strips.forEach(strip => {
const imageUrl = strip.imageUrl
delete strip.imageUrl
strip.imageUrls = [ imageUrl ]
})
return [ id, seriesObject ]
} The bigger project is changing every place that references If you're familiar with JavaScript, I don't think this would be very hard... But that's pretty easy for me to say since I'm familiar with my own project. I don't feel like I have time to make this change myself. Please reply with any more questions. Adding TinyView would be its own project, quite separate to the |
I was trying to add support for it myself but it doesn't follow the existing models very nicely. I'll share some of what I've found:
To get a listing of all comics:
GET
https://storage.googleapis.com/tinyview-d78fb.appspot.com/tinyview/comic-series-directory/directory.jsonTo get the list of urls for a specific comic:
POST
https://us-central1-tinyview-d78fb.cloudfunctions.net/getComicsThe comics come in individual panels. To get their image URLs:
GET
https://storage.googleapis.com/tinyview-d78fb.appspot.com/itchy-feet/2023/10/22/unconditional-love/index.jsoneg: https://storage.googleapis.com/tinyview-d78fb.appspot.com/itchy-feet/2023/10/22/unconditional-love/1.jpg
If you can only do a single image, it'll still be nice to show the preview image and encourage folks to visit the site directly. I am just annoyed they don't have RSS.
Let me know if you need additional guidance or questions.
Really appreciate this service.
The text was updated successfully, but these errors were encountered: