From 02a8f4557b1781f7647b628ab98d6f3cea9a1afd Mon Sep 17 00:00:00 2001 From: Aryan Godara <65490434+AryanGodara@users.noreply.github.com> Date: Tue, 2 Apr 2024 12:10:57 +0530 Subject: [PATCH] Update SpecVersion to stop returning InternalError for nil errors (#549) * fix starknet_specVersion handler --- rpc/version.go | 5 ++++- rpc/version_test.go | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/rpc/version.go b/rpc/version.go index cf6cffec..e7cff4ec 100644 --- a/rpc/version.go +++ b/rpc/version.go @@ -8,5 +8,8 @@ import "context" func (provider *Provider) SpecVersion(ctx context.Context) (string, error) { var result string err := do(ctx, provider.c, "starknet_specVersion", &result) - return result, Err(InternalError, err) + if err != nil { + return "", Err(InternalError, err) + } + return result, nil } diff --git a/rpc/version_test.go b/rpc/version_test.go index 259073bc..d4d889ab 100644 --- a/rpc/version_test.go +++ b/rpc/version_test.go @@ -20,7 +20,7 @@ func TestSpecVersion(t *testing.T) { "mainnet": {}, "mock": {}, "testnet": {{ - ExpectedResp: "0.6.0", + ExpectedResp: "0.7.0", }}, }[testEnv]