Skip to content
This repository has been archived by the owner on Sep 8, 2023. It is now read-only.

[1.18.2] Compatibility issue with Mowzie's Mobs #59

Open
BobMowzie opened this issue Sep 6, 2022 · 2 comments
Open

[1.18.2] Compatibility issue with Mowzie's Mobs #59

BobMowzie opened this issue Sep 6, 2022 · 2 comments

Comments

@BobMowzie
Copy link

BobMowzie commented Sep 6, 2022

Seems we've got an interaction issue! My players report that with Mowzie's Mobs sunstrikes cause server lag when paired with Radium. Here's a profile showing the slowdown: https://spark.lucko.me/B1mRrOLFWr

In my sunstrike class, I run this code:

AABB region = new AABB(getX() - radius, getY() - 0.5, getZ() - radius, getX() + radius, Double.POSITIVE_INFINITY, getZ() + radius);
List<Entity> entities = level.getEntities(this, region);

My first guess is that Radium doesn't like the infinite bounding box. Any idea if this is the case?

@LordSeabass
Copy link

This

@Kriper1111
Copy link

Seems like they do have a handover to vanilla fetching with large enough distances horizontally, just not vertically.
One could add a similar check to

for maxY, which would help. Or pick a saner limit, although the optimization does work best on shorter queries.. Probably.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants