Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smooth Scrolling Plugin seems broke some external URLs with # #29

Closed
alexsuslin opened this issue Mar 19, 2019 · 1 comment
Closed

Smooth Scrolling Plugin seems broke some external URLs with # #29

alexsuslin opened this issue Mar 19, 2019 · 1 comment

Comments

@alexsuslin
Copy link

Expectation

Go to webpage https://atlassianps.org/docs/Contributing/
and click on Homepage link under thank you quoted message

Status Quo

I am expecting to be redirected to https://atlassianps.org/#people, however the link is not working on chrome and edge browsers

My suggestion

$('a[href*="#"]:not([href="#"]), a.inpage-navigation[href*="#"]').on('click', function (event) { event.preventDefault(); smoothScroll($(this.hash)); });

change to
$('a[href^="#"]:not([href="#"]), a.inpage-navigation[href*="#"]').on('click', function (event) { event.preventDefault(); smoothScroll($(this.hash)); });

in the theme.js file, as I bet smooth scroll broke such URLs

@lipkau
Copy link
Member

lipkau commented Mar 21, 2019

fixed in #30

@lipkau lipkau closed this as completed Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants