Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publishing stops if it can't remove the previous pin #47

Open
xuv opened this issue Feb 22, 2022 · 0 comments
Open

Publishing stops if it can't remove the previous pin #47

xuv opened this issue Feb 22, 2022 · 0 comments

Comments

@xuv
Copy link

xuv commented Feb 22, 2022

I've encountered this error in a project of mine that I could not update for months. And where the previous pin had been removed between between two runs of the publishing process.

INFO:publish.publishing:Unpinning hash: /ipfs/<some_previously_pinned_hash_here>/
ERROR:publish.publishing:not pinned or pinned indirectly

In case the publishing script does not manage to remove the previous pin, it will exit.
After checking IPFS documentation on pinning, it seems this can only happen if the pin is not in the local list anymore.

This does not seem to be a big issue and we could probably just ignore this error if it happens and continue the rest of the publishing process.

This is what I've attempted with a patch like you will find here: xuv@6a9825e

Happy to create a PR for it if you find this useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant