Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create MapPropertyType, change MapProperty to use it #449

Open
ljacqu opened this issue Oct 8, 2024 · 0 comments
Open

Create MapPropertyType, change MapProperty to use it #449

ljacqu opened this issue Oct 8, 2024 · 0 comments
Labels
good-first-issue Want to contribute? This label marks well-defined, [relatively] straightforward issues
Milestone

Comments

@ljacqu
Copy link
Member

ljacqu commented Oct 8, 2024

To do

  • Introduce a MapPropertyType, similar to ListPropertyType etc.
    • Make sure it can be created in different ways as in CollectionPropertyType: allow to supply a custom PropertyType<Map<String, …>> but also make it possible to just specify the PropertyType<V> valueType
    • Note: The keys of a Map are always String. This should not be overridable!
  • Add unit tests

Notes

The result map property type and map property should be similar to SetPropertyType and SetProperty: make sure the entries are kept in insertion order (i.e. use LinkedHashMap) and that the default value / returned values are immutable.

@ljacqu ljacqu added the good-first-issue Want to contribute? This label marks well-defined, [relatively] straightforward issues label Oct 8, 2024
@ljacqu ljacqu added this to the 2.0.0 milestone Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-issue Want to contribute? This label marks well-defined, [relatively] straightforward issues
Development

No branches or pull requests

1 participant