Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to deploy the stack #16

Closed
agiusalexandre opened this issue May 3, 2024 · 3 comments
Closed

Unable to deploy the stack #16

agiusalexandre opened this issue May 3, 2024 · 3 comments

Comments

@agiusalexandre
Copy link

Unable to deploy the stack because of s3 CORS policy

@wparad
Copy link
Member

wparad commented May 3, 2024

That hopefully shouldn't be the case. Can you provide the exact error you are getting along with a link to the current deployed website that we can test going to?

@agiusalexandre
Copy link
Author

Yes, I apologize for the limited details I provided. While deploying the SAM Resource within the CloudFormation stack creation process, specifically during the creation of the BucketForS3ExplorerSavedConfiguration resource, I encountered a 'validation failed' status with the following message: 'Properties validation failed for resource BucketForS3ExplorerSavedConfiguration with the message: [#/CorsConfiguration/CorsRules/0/AllowedOrigins: array items are not unique].

@wparad wparad closed this as completed in 933910f May 4, 2024
wparad added a commit that referenced this issue May 4, 2024
@wparad
Copy link
Member

wparad commented May 4, 2024

Great thank you. This has been fixed now. However, the problem should only happen when you haven't set a custom domain, which I assume you might actually want to do. Is there a reason that one wasn't added here? So that might be the pertinent question. But in any case this has been resolved, thank you for the report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants