Fix left handed indexed meshes with normals #2233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libs/render_delegate/mesh.cpp
Outdated
| bool isLeftHanded = false; | ||
| // We have to flip the orientation if it's left handed. | ||
| const auto topology = GetMeshTopology(sceneDelegate); | ||
| bool isLeftHanded = topology.GetOrientation() == PxOsdOpenSubdivTokens->leftHanded; |
There was a problem hiding this comment.
I'm a bit worried of moving the GetMeshTopology outside of the "if (dirtyTopology)" as this function seems to have a cost, and we can be called multiple times in Sync even when there's nothing to change.
I think we should either store a bool member _isLeftHanded in the class, of call GetMeshTopology again inside of "if (dirtyPrimvars)", of create an empty HdMeshTopology and set it only "if (dirtyPrimvars || dirtyTopology)" so that the topology can be used inside of both tests, but the more we can remove from outside of the dirtiness tests, the better
sebastienblor
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rendering left handed indexed meshes with normals with husk, the sync function is called twice and the second time the leftHanded variable is not correctly set which ends up having the normal indices incorrectly set.
Issues fixed in this pull request
Fixes #2232